Fix handling of the root path in WasiFS resulting in a bad inode structure #5285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arshia001
changed the title
* Fix renaming a directory that was created with mkdir * Fix inodes' name becoming stale after a rename * Add test for mkdir -> rename -> mkdir * Fix opening files in the presence of a non-default CWD * Fix deadlock when base FD is not / or .
Arshia001
force-pushed
the
fix/mkdir-rename-mkdir
branch
from
293faee to
edcef5a
Compare
This allows syscalls with base FD+path input to work correctly with non-root base FDs
…ersion as everything else
theduke
reviewed
Dec 10, 2024
theduke
approved these changes
Dec 10, 2024
|
I'll force-merge since macos tests seem to be on a halt atm |
|
They started running once I restarted them, albeit very slowly and one-by-one. I'll keep an eye on the CI pipeline for possible failures we may want to correct in a later PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description